Skip to content

Stricter rules from ruff#123

Merged
suricactus merged 59 commits intomasterfrom
stricter_rules_and_fixes
Aug 26, 2025
Merged

Stricter rules from ruff#123
suricactus merged 59 commits intomasterfrom
stricter_rules_and_fixes

Conversation

@suricactus
Copy link
Copy Markdown
Collaborator

@suricactus suricactus commented Aug 12, 2025

See individual commits for all the changes.

In a follow-up ANN and FA100 will not be ignored anymore.

@suricactus
refactor: remove outdated utf8 encoding declaration, ruff UP009
dc7cbdf
@suricactus
refactor: add empty line after the last doc section, ruff D413
b314d90
@suricactus
refactor: add missing colon in docstring, ruff D416
bc224d8
@suricactus
refactor: add blank line before sections, ruff D411
be89643
@suricactus
refactor: make comment single line when possible, ruff D200
bc5cd94
@suricactus
refactor: remove useless inheritance from object, ruff UP004
0f47c1b
@suricactus
refactor: use short list definition, ruff C408
913256e
@suricactus
refactor: do not call super() with parameters, ruff UP008
96610d2
@suricactus
refactor: multiline docstrings should have the first line empty, ruff…
e6de8ec 
… D213
@suricactus
refactor: return single line condition, ruff SIM103
afc0310
@suricactus
refactor: remove empty lines after a dostring, ruff D202
5f2297d
@suricactus
refactor: prefer str.format rather than % operator, ruff UP031
a418715
@suricactus
refactor: defined mutable classvars, ruff RUF012
11ce528
@suricactus
refactor: no implicit return of None, ruff RET502
35c724d
@suricactus
refactor: proper negation with !=, ruff SIM201
4328d18
@suricactus
refactor: use dict.get instead of if/else, ruff SIM401
e487065
@suricactus
refactor: no NOQA without a code, ruff RUF100
7def5fb
@suricactus
ruff: make sure the class names are CamelCase unless when they should…
a294034 
…n't, ruff N801
@suricactus
refactor: prefer f-strings over format, ruff UP032
bba4875
@suricactus
refactor: fix shadowing of variables, ruff A001
5c135a3
@suricactus
refactor: no need to pass 0 as a start in range(0, N), ruff PIE808
b8f7cfd
@suricactus
refactor: explicitly state the function is used for checksum calculat…
9a8f551 
…ion, not security, ruff S324
@suricactus
refactor: in PEP8 it is defined that all exception should suffix in `…
73a5464 
…Error`, ruff N818
@suricactus
refactor: ensure that too many arguments is not checked for some func…
6531df9 
…tions, ruff PLR0913
@suricactus
refactor: use conversion flag instead of function, ruff RUF010
f7fceaf
@suricactus
refactor: fix redefining argument with the local name e_layer, ruff…
12b4f7c 
… PLR1704
@suricactus
refactor: when there is break, no need for elif, ruff RET508
ae84f35
@suricactus
refactor: fix backwards compatible typing, ruff FA102
a950d4a
@suricactus
refactor: do not defined unused variable, ruff B007
a7803e8
@suricactus
refactor: no repeated equality, but check with in operator, ruff PL…
2fa9e88 
…R1714
@suricactus suricactus requested a review from nirvn August 12, 2025 17:03
@suricactus suricactus force-pushed the stricter_rules_and_fixes branch from af08a2f to bb2b3b2 Compare August 12, 2025 17:05
@suricactus suricactus mentioned this pull request Aug 12, 2025
Merged
@suricactus
refactor: rename pascalCased signals to snake_case, ruff N815
2e40108
@suricactus
refactor: kill unused OfflineConverter.convertorProcessingProgress …
58cf072 
…function
@suricactus
refactor: rename pascalCased methods to snake_case, ruff N802
e530811
@suricactus
refactor: fix typing and overload of `BadLayerHandler.handleBadLayers…
06e0922 
…` in compatible manner with the base class
@suricactus
refactor: remove print statements, ruff T201
e224d19
@suricactus
refactor: typing issues, enable PGH003
8600d7c
@suricactus
refactor: allow check_layer_has_experimental_cloud_support to have …
1ddadd7 
…many return statements
@suricactus
refactor: simplify _convert_to_offline_project by adding `_get_data…
7b7e961 
…source_mapping`
@suricactus
refactor: improve typing in convert_to_gpkg
413b9fc
@suricactus
refactor: ignore branching whenever needed, ruff PLR0912 PLR0915
d76ffb8
@suricactus
refactor: remove a comment from the flake8 era, but we are now ruff
48565ab
@suricactus
feature: added new ruff rules
b433d1b
@suricactus
refactor: rename CheckConfig.type to CheckConfig.level, ruff A003
5274d6e
@suricactus
refactor: make the project checker use old annotations, ruff FA102
3abd6d4
@suricactus suricactus force-pushed the stricter_rules_and_fixes branch from ba650c4 to 3abd6d4 Compare August 26, 2025 05:56
nirvn
nirvn approved these changes Aug 26, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@nirvn nirvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@suricactus suricactus merged commit cca9618 into master Aug 26, 2025
6 checks passed
@suricactus suricactus deleted the stricter_rules_and_fixes branch August 26, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nirvn nirvn nirvn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@suricactus @nirvn