Fix QGIS plugin reload cleanup#96
Merged
Merged
Conversation
|
🚀 Deployed on https://6a02ac3b3921219773017512--opengeos.netlify.app |
for more information, see https://pre-commit.ci
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves QGIS plugin reload/unload behavior by proactively cleaning up stale UI elements (toolbars/menus) that can remain attached to the QGIS main window, reducing Plugin Reloader warnings.
Changes:
- Adds best-effort removal of existing/stale toolbars by object name before creating a new toolbar and during unload.
- Adds best-effort removal of existing/stale plugin menus by title before initialization and during unload.
- Centralizes toolbar/menu cleanup into helper methods that attempt to detach and schedule deletion safely.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix QGIS Plugin Reloader warnings caused by custom plugin toolbars and menus that can remain attached to the QGIS main window after
unload().Changes
Validation
python -m py_compileon the changed plugin entry-point file.git diff --check.