Skip to content

Conversation

@hyejang
Copy link
Contributor

@hyejang hyejang commented Mar 2, 2020

openff-1.1.0.offxml and openff_unconstrained-1.1.0.offxml were added. Details about the version 1.1.0 can be found in openforcefield/openforcefield-forcebalance/releases/tag/v1.1.0.

@hyejang
Copy link
Contributor Author

hyejang commented Mar 2, 2020

@j-wags could you double-check if the PR looks correct?

@jchodera
Copy link
Member

jchodera commented Mar 2, 2020

@hyejang : Was this a manual bugfix or an automated refit with new types?
According to our semantic versioning, if it was a manual bugfix, it would be 1.0.1, but if you refit the parameters, it should be 1.1.0.

@hyejang
Copy link
Contributor Author

hyejang commented Mar 2, 2020

@jchodera I think you are right. I'll change the version number to 1.1.0. Thanks for pointing it out.

@hyejang hyejang changed the title Version 1.0.1 Parsley Version 1.1.0 Parsley Mar 2, 2020
@j-wags
Copy link
Member

j-wags commented Mar 2, 2020

Great. @hyejang, do you have a tarball with the original QM data, scripts, and environment for this? I think we'll want to make that a release in openforcefield-forcebalance, and link that in the release notes in this repo.

@j-wags j-wags mentioned this pull request Mar 2, 2020
@j-wags
Copy link
Member

j-wags commented Mar 2, 2020

Ahhh, I see, the linked release was originally called 1.0.1, but had outdated/erroneous benchmarking results, so the release was modified and the assets were updated. I think this is fine, since the openforcefield-forcebalance repo is not hooked up to Zenodo, so the there won't be any conflicting sources of information out there about this release.

Copy link
Member

@j-wags j-wags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Merge when you're ready!

@j-wags j-wags merged commit 9aad241 into openforcefield:master Mar 3, 2020
@jchodera
Copy link
Member

jchodera commented Mar 3, 2020

Hooray! Thanks so much for tackling this, @hyejang! It's exciting to see the force fields keep getting better!

@lilyminium lilyminium mentioned this pull request Jul 22, 2024
20 tasks
@lilyminium lilyminium mentioned this pull request Sep 11, 2024
20 tasks
@lilyminium lilyminium mentioned this pull request Sep 12, 2025
15 tasks
@lilyminium lilyminium mentioned this pull request Jan 1, 2026
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants