-
Notifications
You must be signed in to change notification settings - Fork 26
Version 1.1.0 Parsley #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@j-wags could you double-check if the PR looks correct? |
|
@hyejang : Was this a manual bugfix or an automated refit with new types? |
|
@jchodera I think you are right. I'll change the version number to 1.1.0. Thanks for pointing it out. |
|
Great. @hyejang, do you have a tarball with the original QM data, scripts, and environment for this? I think we'll want to make that a release in openforcefield-forcebalance, and link that in the release notes in this repo. |
|
Ahhh, I see, the linked release was originally called 1.0.1, but had outdated/erroneous benchmarking results, so the release was modified and the assets were updated. I think this is fine, since the |
fix some irregular whitespace
j-wags
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Merge when you're ready!
|
Hooray! Thanks so much for tackling this, @hyejang! It's exciting to see the force fields keep getting better! |
openff-1.1.0.offxmlandopenff_unconstrained-1.1.0.offxmlwere added. Details about the version 1.1.0 can be found in openforcefield/openforcefield-forcebalance/releases/tag/v1.1.0.