Skip to content

Fix connectTimeout configuration usage #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jimmyjames merged 1 commit into from
Jul 15, 2025
Merged

Fix connectTimeout configuration usage #182

jimmyjames merged 1 commit into from
Jul 15, 2025

Conversation

@aaguiarz
Copy link
Member

@aaguiarz aaguiarz commented Jul 15, 2025 •
edited by coderabbitai bot
Loading

Summary

  • propagate connectTimeout from Configuration to ApiClient builder
  • forward the setting through OAuth2Client

Testing

  • ./gradlew test

https://chatgpt.com/codex/tasks/task_e_68767c176db88322b80f8d3ec423d404

Summary by CodeRabbit

  • New Features
    • Added support for configuring connection timeout for the API client and OAuth2 client, allowing users to set custom connection timeouts for improved control over network behavior.

@aaguiarz aaguiarz requested a review from a team as a code owner July 15, 2025 16:30
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 15, 2025 •
edited
Loading

Walkthrough

The constructors of the OpenFgaApi and OAuth2Client classes were updated to support configuring the HTTP connection timeout. The connectTimeout setting is now propagated from the configuration and applied to the HTTP client builder, enabling the customization of connection timeout behavior for API requests.

Changes

File(s) Change Summary
src/main/java/dev/openfga/sdk/api/OpenFgaApi.java Modified constructor to retrieve connectTimeout from configuration and set it on the HTTP client.
src/main/java/dev/openfga/sdk/api/auth/OAuth2Client.java Updated constructor to copy connectTimeout from input configuration to internal configuration.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant OAuth2Client
    participant Configuration
    participant OpenFgaApi
    participant ApiClient
    participant HttpClientBuilder

    User->>OAuth2Client: Instantiate with Configuration
    OAuth2Client->>Configuration: Copy properties (including connectTimeout)
    User->>OpenFgaApi: Instantiate with Configuration
    OpenFgaApi->>ApiClient: Set default headers
    OpenFgaApi->>Configuration: Retrieve connectTimeout
    OpenFgaApi->>ApiClient: Set connectTimeout on HttpClientBuilder (if present)
Loading
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9ac9fa0 and 9a23764.

📒 Files selected for processing (2)
  • src/main/java/dev/openfga/sdk/api/OpenFgaApi.java (1 hunks)
  • src/main/java/dev/openfga/sdk/api/auth/OAuth2Client.java (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Analyze (java)
🔇 Additional comments (2)
src/main/java/dev/openfga/sdk/api/OpenFgaApi.java (1)

94-97: LGTM! Correct implementation of connectTimeout propagation.

The implementation properly retrieves the connectTimeout from the configuration and applies it to the ApiClient's HTTP client builder. The null check ensures safe handling when the timeout is not configured, and the placement in the constructor is appropriate for configuration setup.

src/main/java/dev/openfga/sdk/api/auth/OAuth2Client.java (1)

52-52: LGTM! Proper connectTimeout propagation to OAuth2Client.

The addition of connectTimeout(configuration.getConnectTimeout()) ensures that the timeout setting is consistently propagated to the OAuth2Client's internal configuration, maintaining alignment with the main API client's timeout configuration.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 33.68%. Comparing base (9ac9fa0) to head (9a23764).

Files with missing lines Patch % Lines
src/main/java/dev/openfga/sdk/api/OpenFgaApi.java 66.66% 0 Missing and 1 partial ⚠️

❌ Your project status has failed because the head coverage (33.68%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main     #182      +/-   ##
============================================
+ Coverage     33.65%   33.68%   +0.02%     
  Complexity     1003     1003              
============================================
  Files           182      182              
  Lines          6890     6894       +4     
  Branches        776      777       +1     
============================================
+ Hits           2319     2322       +3     
  Misses         4467     4467              
- Partials        104      105       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jimmyjames jimmyjames added this pull request to the merge queue Jul 15, 2025
Merged via the queue into main with commit a48bc3a Jul 15, 2025
24 checks passed
@jimmyjames jimmyjames deleted the codex/fix-issue-147-in-java-sdk branch July 15, 2025 18:09
This was referenced Jul 15, 2025
Closed
Merged
Merged
@jimmyjames jimmyjames mentioned this pull request Jul 22, 2025
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jimmyjames jimmyjames jimmyjames approved these changes

Assignees

No one assigned

Labels

codex

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aaguiarz @codecov-commenter @jimmyjames