Skip to content

feat!: support server-side batch check endpoint #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jimmyjames merged 1 commit into from
Feb 5, 2025
Merged

feat!: support server-side batch check endpoint #141

jimmyjames merged 1 commit into from
Feb 5, 2025

Conversation

@piotrooo
Copy link
Contributor

@piotrooo piotrooo commented Feb 5, 2025 •
edited by rhamzeh
Loading

Description

References

closes #127
openfga/sdk-generator#475

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@piotrooo piotrooo requested review from a team as code owners February 5, 2025 18:43
@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 85.45455% with 24 lines in your changes missing coverage. Please review.

Project coverage is 32.78%. Comparing base (c249fb6) to head (6e9777a).

Files with missing lines Patch % Lines
...i/client/model/ClientBatchCheckClientResponse.java 59.25% 9 Missing and 2 partials ⚠️
...java/dev/openfga/sdk/api/client/OpenFgaClient.java 89.18% 4 Missing and 4 partials ⚠️
...fga/sdk/api/client/model/ClientBatchCheckItem.java 89.47% 2 Missing ⚠️
...i/configuration/ClientBatchCheckClientOptions.java 88.23% 2 Missing ⚠️
.../sdk/api/client/model/ClientBatchCheckRequest.java 80.00% 1 Missing ⚠️

❌ Your project status has failed because the head coverage (32.78%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main     #141      +/-   ##
============================================
+ Coverage     29.82%   32.78%   +2.96%     
- Complexity      890      973      +83     
============================================
  Files           176      182       +6     
  Lines          6746     6872     +126     
  Branches        756      764       +8     
============================================
+ Hits           2012     2253     +241     
+ Misses         4632     4512     -120     
- Partials        102      107       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jimmyjames
jimmyjames approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@jimmyjames jimmyjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jimmyjames jimmyjames added this pull request to the merge queue Feb 5, 2025
Merged via the queue into openfga:main with commit fdab6d2 Feb 5, 2025
11 checks passed
@jimmyjames jimmyjames mentioned this pull request Feb 5, 2025
Merged
4 tasks
@piotrooo piotrooo deleted the feat/batch-check branch February 6, 2025 05:41
@jimmyjames jimmyjames mentioned this pull request Feb 7, 2025
Merged
4 tasks
@aaguiarz aaguiarz mentioned this pull request May 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jimmyjames jimmyjames jimmyjames approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Java sdk batchCheck does not do a batch check

3 participants

@piotrooo @codecov-commenter @jimmyjames