Skip to content

Add suppress-summary flag to model test command #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rhamzeh merged 6 commits into from
Mar 25, 2025
Merged

Add suppress-summary flag to model test command #407

rhamzeh merged 6 commits into from
Mar 25, 2025

Conversation

@Siddhant-K-code
Copy link
Member

@Siddhant-K-code Siddhant-K-code commented Oct 15, 2024 •
edited
Loading

Description

This pull request adds a new flag, suppress-summary, to the test command. When this flag is set to true, the plain text summary output will be suppressed. This provides more flexibility for users who prefer not to see the summary output.

How to test

go run main.go model test --tests /workspace/openfga-cli/example/model.fga.yaml --verbose --suppress-summary

References

fixes #385

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

If you haven't done so yet, we would appreciate it if you could star the OpenFGA repository. :)

@Siddhant-K-code Siddhant-K-code requested a review from a team as a code owner October 15, 2024 15:49
@Siddhant-K-code Siddhant-K-code changed the title Add suppress-summary flag to test command Add suppress-summary flag to modal test command Oct 15, 2024
@Siddhant-K-code Siddhant-K-code changed the title Add suppress-summary flag to modal test command Add suppress-summary flag to model test command Oct 15, 2024
@Siddhant-K-code

This comment was marked as resolved.

Sign in to view
@Siddhant-K-code Siddhant-K-code mentioned this pull request Oct 15, 2024
Closed
@Siddhant-K-code
Copy link
Member Author

Siddhant-K-code commented Oct 21, 2024

@evansims, any plans to introduce this feature to --verbose command?

@Siddhant-K-code
Copy link
Member Author

Siddhant-K-code commented Mar 25, 2025

cc: @rhamzeh

rhamzeh
rhamzeh approved these changes Mar 25, 2025
View reviewed changes
Copy link
Member

@rhamzeh rhamzeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Siddhant-K-code!

@rhamzeh rhamzeh added this pull request to the merge queue Mar 25, 2025
Merged via the queue into openfga:main with commit 9ab3743 Mar 25, 2025
15 checks passed
@Siddhant-K-code Siddhant-K-code deleted the fix/385 branch March 25, 2025 14:42
@rhamzeh rhamzeh mentioned this pull request Apr 23, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhamzeh rhamzeh rhamzeh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fga model test --verbose output should be easy to parse

2 participants

@Siddhant-K-code @rhamzeh