Skip to content

Fix city resolution and test coverage#7

Merged
ahalterman merged 4 commits intomasterfrom
place_picking
Jul 10, 2016
Merged

Fix city resolution and test coverage#7
ahalterman merged 4 commits intomasterfrom
place_picking

Conversation

@ahalterman
Copy link
Copy Markdown
Member

This PR is focused on fixing a bug in city name resolution (#1) with some associated other improvements:

  • Resolve Prevent cities being geocoded to things inside the city #1, which deals with cities being resolved to places inside the city, rather than the city itself. This was the result of trying to narrowing the Elasticsearch query using keywords from the vicinity of the place name. Just doing a regular query gives much better results. Future work can figure out if it makes sense to add back in query_geonames_featureclass.
  • Move the MITIE entity extraction of /places from the post function to the process function, which makes more sense and makes it easier to test.
  • Greatly expand test coverage to include MITIE, query_geonames, and whether cities are correctly resolved.
  • Make a small change to config to allow a custom Elasticsearch port.

@ahalterman
Copy link
Copy Markdown
Member Author

Also:

@ahalterman ahalterman merged commit 0e86e3f into master Jul 10, 2016
@ahalterman ahalterman deleted the place_picking branch January 27, 2017 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prevent cities being geocoded to things inside the city

1 participant