This repository was archived by the owner on May 24, 2022. It is now read-only.
Rewrite post$ to take a password and not use signer#93
Merged
axelchalon merged 12 commits intomasterfrom Jan 22, 2019
Merged
Conversation
amaury1093
reviewed
Jan 16, 2019
Collaborator
amaury1093
left a comment
There was a problem hiding this comment.
Could you also bump all @parity/* packages and deps to ^4.0.0?
| observer.next({ confirmed: receipt }); | ||
| } | ||
| const signedTransaction = await api.personal.signTransaction(tx, passphrase); | ||
| postRaw$(signedTransaction.raw).subscribe(observer); |
Collaborator
There was a problem hiding this comment.
Since this is a breaking change, what do you think of putting observer.next({ signed: ... }) here
| try { | ||
| const transactionHash = await api.eth.sendRawTransaction(tx); | ||
| const transactionHash = await api.eth.sendRawTransaction(rawTx); | ||
| observer.next({ signed: transactionHash }); |
Collaborator
There was a problem hiding this comment.
... and changing here to observer.next({ sent: ... })
Closed
amaury1093
reviewed
Jan 18, 2019
Collaborator
amaury1093
left a comment
There was a problem hiding this comment.
Conflicts need to be solved. Can you also bump inside lerna.json?
amaury1093
approved these changes
Jan 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change to the post$ API (before:
tx, options; now:tx, passphrase, options). Should bump version consequently.post$ now doesn't require any subsequent action from the caller (no more signer_ rpcs). post$ uses
personal_signTransactionwith the tx and passphrase to get the signed tx, and callspostRaw$with it.Con: AFAIK the
personalapi needs to be activated in Parity's launch flag--ws-apis(unless the secure token covers this; haven't checked).