Conversation
12bcfbf to
6f2b5d6
Compare
amaury1093
left a comment
There was a problem hiding this comment.
Looks good overall, just not 100% sure if we should error the Observable
| ); | ||
| console.groupEnd(); | ||
| return empty(); | ||
| return throwError(err) as Observable<U>; |
There was a problem hiding this comment.
Could we actually remove the catchError block altogether? Also, the function comment should be modified.
On another note: The reason I initially wanted to return empty() was because of e.g. balanceOf$(), if one of the eth_getBalance calls fails for whatever reason, then the whole Observable errors and stops. In fether, I had some occasions where transactionCount$ failed once or twice because of the light node, but it retried on new head, so the overall behavior was okay. I just don't want transactionCount$ to stop completely if one of the eth_getTransactionCount fails.
package.json
Outdated
| "typedoc-plugin-markdown": "^1.1.13", | ||
| "typescript": "^3.1.6" | ||
| }, | ||
| "dependencies": { |
There was a problem hiding this comment.
I believe this shouldn't be here
Some changes required for openethereum/fether#204
options.emitErrors === true. This is needed to check the version of the running instance of Parity (part of Bundle Parity Ethereum in Fether's binary fether#204): if the RPC parity_versionInfo fails, we know that we're running Parity Ethereum <v2.4.1 (in fether-react)parityPathto runParity and signerNewToken, which lets us run those commands on the bundled Parity binary