This repository was archived by the owner on May 24, 2022. It is now read-only.
Merged
Conversation
axelchalon
reviewed
Sep 2, 2019
| !arg.startsWith('--ws-interface') | ||
| ) | ||
| ); | ||
| .parse(process.argv); |
Contributor
There was a problem hiding this comment.
My hunch is that Electron or MacOs would be pass down flags to Electron, which are unexpected on our side and would make the program exit with error code != 0 (because we don't allow unknown arguments anymore). I think I would keep the filtering of process.argv ?
parse(
process.argv
// We want to ignore some flags and not pass them down to Parity:
// --inspect: `electron-webpack dev` runs Electron with the `--inspect` flag for HMR
// -psn_*: https://github.com/paritytech/fether/issues/188
// --ws-interface: we don't pass down this flag, because fether only allows 127.0.0.1 as WS interface
.filter(
arg =>
!arg.startsWith('--inspect') &&
!arg.startsWith('-psn_') &&
!arg.startsWith('--ws-interface')
)
Collaborator
Author
There was a problem hiding this comment.
It seems that --inspect is not passed by electron-webpack anymore, so we can remove that one. --ws-interface has been removed.
You're probably right, i'll keep arg => !arg.startsWith('-psn_') just to be sure
Tbaut
approved these changes
Sep 3, 2019
Collaborator
Tbaut
left a comment
There was a problem hiding this comment.
tested with yarn electron --chain kovan successfully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #550
Only two flags possible:
--chain--no-run-parity: kept this one, iirc was requested a couple of times in parity ui, and harmlessAny other flags will exit Fether with error code != 0.