This repository was archived by the owner on May 24, 2022. It is now read-only.
Merged
Conversation
Contributor
|
maybe we can also use the csp meta in dev for the sake of simplicity, and remove the csp handling in edit: csps differ and it seems to be too much of a hassle, nevermind |
amaury1093
suggested changes
May 3, 2019
Collaborator
There was a problem hiding this comment.
After fixing grumbles I'll try with yarn start and yarn electron. It's mainly playing around until we find the most restrictive CSP which makes the app work.
@axelchalon Agreed! I played a bit on light-ui, the only additional thing we need in yarn start is connect-src: http:; for hot-reloading, but I would propose to remove everything in onHeadersReceived and to drop hot-reloading
amaury1093
approved these changes
May 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #516