fix: stop using an empty enqued style in all contexts#79
fix: stop using an empty enqued style in all contexts#79MaferMazu merged 1 commit intoopenedx:mainfrom
Conversation
|
Thanks for the pull request, @MaferMazu! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
f8e33ca to
8891ec1
Compare
felipemontoya
left a comment
There was a problem hiding this comment.
This seems very reasonable. However I think we should leave the note a the css file as well saying that is not enqueued and future devs wanting to add styles should also enqueue the file again.
97fb164 to
06cdadd
Compare
06cdadd to
eb5829a
Compare
|
Thanks for the feedback, @felipemontoya. I have already added the note. |
felipemontoya
left a comment
There was a problem hiding this comment.
Thanks a lot. I think this solves it.
|
@MaferMazu 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
This is a quick fix to avoid loading the
openedx-commerce-public.cssin all contexts.I pass the plugin in a Plugin Checker. to check we follow the WordPress standards. And I found this warning:
I only removed the queued action because it is not needed. The
openedx-commerce-public.cssdoesn't have styles.With this PR, the plugin checker responds the following:
Testing instructions
Check if everything is alright in our stage. This version is in our stage: https://share.1password.com/s#ywKsPlWEUFR__qx_a_ZyoT1jyd8DUJQUs4ycraieSRg
Checklist for Merge