fix: file and class names corrected based on wordpress requirements#53
fix: file and class names corrected based on wordpress requirements#53MaferMazu merged 5 commits intoopenedx:mainfrom
Conversation
|
Thanks for the pull request, @julianramirez2! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
|
Hi @julianramirez2! Thanks for this contribution! Please let me know if you have any questions regarding filling out the CLA form. If you are submitting on behalf of an organization, please have your manager reach out to oscm@axim.org in order to be added to your organization's entity agreement. |
Hi @mphilbrick211, thank you for providing the information. I have just completed the CLA form and am now awaiting the email confirmation of my CLA approval. |
MaferMazu
left a comment
There was a problem hiding this comment.
This comes because we needed to change the plugin name to submit to the WordPress org, and we want to maintain the congruency of the names.
I was a little afraid because this could generate breaks, but I already tested in stage, and this doesn't break anything.
|
@julianramirez2 @MaferMazu calling it |
|
We can't use Woocommerce or Plugin in the name of a WordPress plugin. Is it okay to stay with |
|
Let's go with |
|
Also, can we add an ADR or something about this so we have a record of what the restrictions were when we set the name? |
|
@julianramirez2, can you help me with the naming and updating #54? I can create the ADR for this. |
|
H @julianramirez2! It looks like your CLA check is still failing. You mentioned you submitted your CLA form last week, but if you are contributing on behalf of eduNEXT, you'll need to have your manager reach out to oscm@axim.org to be added to eduNEXT's entity agreement (if they haven't done so already). If this has already been done, please let me know and I can check on the status for you. Thanks! |
julianramirez2
left a comment
There was a problem hiding this comment.
Everything looks good
|
@julianramirez2 great! It looks like a few conflicts popped up - would you mind taking a look? |
7a504bb to
53a9ef3
Compare
|
This change is working well |
felipemontoya
left a comment
There was a problem hiding this comment.
Good work @MaferMazu, with the successful test of the code correctly loading and working I think this is good to merge.
794b3af
53a9ef3 to
794b3af
Compare
MaferMazu
left a comment
There was a problem hiding this comment.
I rebase this and It is working well
Tested:
- In new instalation
- Stage
- And with Olive and Quince
feanil
left a comment
There was a problem hiding this comment.
Name change looks good to me.
|
@julianramirez2 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
The file names were changed due to WordPress restrictions when uploading the plugin, which prohibited the use of reserved words such as 'plugin' or 'woocommerce.' It was decided that this name change would be made to 'openedx_ecommerce' instead of 'openedx_woocommerce_plugin.' Similarly, in accordance with WordPress code best practices, the names of the classes and namespaces used in the code were also changed.
Testing instructions
Pull the branch locally and run the 'composer install' command to install all plugin dependencies and test. Additionally, these changes have already been uploaded to the staging environment where you can verify that everything is functioning correctly.
Checklist for Merge