feat!: drop legacy dates tab, in favor of MFE version#29846
Merged
Conversation
c423eab to
71bb3b1
Compare
cdeery
approved these changes
Jan 31, 2022
Contributor
cdeery
left a comment
There was a problem hiding this comment.
This looks good to me. Pretty straightforward since it was all under the waffle flag.
Congratulations!
71bb3b1 to
691aeef
Compare
691aeef to
a246911
Compare
48e5ae4 to
1d76b87
Compare
1d76b87 to
2879084
Compare
For the dates courseware tab, we no longer respect the course_home_use_legacy_frontend waffle flag that enabled the legacy version in Maple. Instead, we always send the user to the MFE. MFEs will be required for the Nutmeg release. This dates tab is the first to fall, but others will follow. AA-799
2879084 to
0eb8962
Compare
Contributor
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
Contributor
|
EdX Release Notice: This PR has been deployed to the production environment. |
1 similar comment
Contributor
|
EdX Release Notice: This PR has been deployed to the production environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
THIS IS A BIGGER CHANGE THAN IT LOOKS
This PR is the first to remove a legacy view, so it's the first time that we are officially requiring MFEs. That has been the announced plan, so this is fine. But something to note.
The cleanup would have been more extensive, but a lot of the supporting dates code is still used in the outline tab.
Commit message:
For the dates courseware tab, we no longer respect the course_home_use_legacy_frontend waffle flag that enabled the legacy version in Maple.
Instead, we always send the user to the MFE.
MFEs will be required for the Nutmeg+1 release. This dates tab is the first to fall, but others will follow.
AA-799
openedx/public-engineering#50