Skip to content

fix: course discovery dates localization after user logout#29773

Merged
github-actions[bot] merged 1 commit intoopenedx:open-release/maple.masterfrom
raccoongang:dyudyunov/maple/fix-course-discovery-dates-localization-after-user-logout
Feb 9, 2022
Merged

fix: course discovery dates localization after user logout#29773
github-actions[bot] merged 1 commit intoopenedx:open-release/maple.masterfrom
raccoongang:dyudyunov/maple/fix-course-discovery-dates-localization-after-user-logout

Conversation

@dyudyunov
Copy link
Copy Markdown
Contributor

@dyudyunov dyudyunov commented Jan 17, 2022

Preconditions:

  • course discovery enabled

STR:

  • log in
  • choose any language with a different date format (e.g. Ukrainian)
  • check date format changed on the /courses page
  • logout and go to /courses again

AR:

  • date format is English on /courses, but stays the same as for logged in
    user on the main page

ER:

  • date format stays the same as for logged in user

Related PR to the master branch:

@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels Jan 17, 2022
@openedx-webhooks
Copy link
Copy Markdown

Thanks for the pull request, @dyudyunov! I've created OSPR-6398 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@dyudyunov dyudyunov force-pushed the dyudyunov/maple/fix-course-discovery-dates-localization-after-user-logout branch 2 times, most recently from ce9fd77 to ada176e Compare January 17, 2022 13:55
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was already fixed in the master: d061f64

@natabene
Copy link
Copy Markdown
Contributor

@dyudyunov Thank you for your contribution. @BbrSofiane Could you please review?

@dyudyunov
Copy link
Copy Markdown
Contributor Author

Similar PR to master #29772 was already merged

@cmltaWt0
Copy link
Copy Markdown
Contributor

cmltaWt0 commented Feb 9, 2022

@dyudyunov Please rebase it on top of open-release/maple.master to re-run the tests.

@dyudyunov
Copy link
Copy Markdown
Contributor Author

@dyudyunov Please rebase it on top of open-release/maple.master to re-run the tests.

Got it

Preconditions:
- course discovery enabled

STR:
- log in
- choose any language with different date format (e.g. Ukrainian)
- check date format changed on the /courses page
- logout and go to /courses again

AR:
- date format is English on /courses, but stays the same as for logged in
user on the main page

ER:
- date format stays the same as for logged in user
@dyudyunov dyudyunov force-pushed the dyudyunov/maple/fix-course-discovery-dates-localization-after-user-logout branch from ada176e to 0fe44fa Compare February 9, 2022 08:01
@cmltaWt0
Copy link
Copy Markdown
Contributor

cmltaWt0 commented Feb 9, 2022

@openedx-community-bot merge

@github-actions github-actions Bot merged commit d1de524 into openedx:open-release/maple.master Feb 9, 2022
@openedx-webhooks
Copy link
Copy Markdown

@dyudyunov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge merged open-source-contribution PR author is not from Axim or 2U

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants