Conversation
|
Your PR has finished running tests. There were no failures. |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
|
EdX Release Notice: This PR has been rolled back from the production environment. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
|
EdX Release Notice: This PR has been rolled back from the production environment. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
|
EdX Release Notice: This PR has been rolled back from the production environment. |
1 similar comment
|
EdX Release Notice: This PR has been rolled back from the production environment. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
Fix the issue that was preventing us from upgrading pytest. pytest does some manipulation of test packages that prevents
pkg_resourcesfrom loading resources from them, but used to contain a workaround for the problem. That workaround was removed in 4.6.0 as a performance enhancement when pytest switched frompkg_resourcestoimportlib-metadatafor its own entrypoint handling. This tripped up one of our test modules which defined classes that loaded templates from inside a test package. Moving these resources to the parent package fixes the problem.More and more,
pkg_resourcesis being abandoned in favor ofimportlib-metadataandimportlib_resourcesas they have a simpler design with much better performance. However,importlib_resourcesdoesn't support loading files from any directory which isn't itself a Python package (and doesn't allow direct use of paths including directories within the package). Jinja2 chose a different approach that we may want to emulate in our resource handling.Also fixed usage of a removed
pytest.raises()parameter and a bug in our configuration of thecommon/libtests that became a problem after the upgrade.