Update download_models.py#824
Merged
alalek merged 1 commit intoopencv:3.4from Dec 4, 2020
muare:master
Merged
Conversation
Member
|
Thank you for contribution! This patch should go into 3.4 branch first. Please:
Note: no needs to re-open PR, apply changes "inplace". |
The fix for issue (opencv/opencv_contrib#941) introduced a defect. Steps to reproduce the defect: 1. download model GoogleNet using command on windows: python download_models.py GoogleNet 2. there is an exception and downloading is failed. Root cause analysis 1. filename is "bvlc_googlenet.caffemodel" 2. the basedir for model storage is empty with following statement basedir = os.path.dirname(self.filename) 3. os.path.mkdir('') throws exception Traceback (most recent call last): File "download_models.py", line 883, in <module> if not m.get(): File "download_models.py", line 66, in get os.makedirs(basedir, exist_ok=True) File "C:\Users\xiebian\miniconda3\envs\gluon\lib\os.py", line 220, in makedirs mkdir(name, mode) FileNotFoundError: [WinError 3] 系统找不到指定的路径。: ''
Contributor
Author
|
@alalek thanks for the detailed instruction and it's done. |
alalek
approved these changes
Dec 4, 2020
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix for issue (opencv/opencv_contrib#941) introduced a defect.
Steps to reproduce the defect:
Root cause analysis
basedir = os.path.dirname(self.filename)
Traceback (most recent call last):
File "download_models.py", line 883, in
if not m.get():
File "download_models.py", line 66, in get
os.makedirs(basedir, exist_ok=True)
File "C:\Users\xiebian\miniconda3\envs\gluon\lib\os.py", line 220, in makedirs
mkdir(name, mode)
FileNotFoundError: [WinError 3] 系统找不到指定的路径。: ''