Merged
Conversation
dkurt
reviewed
May 27, 2020
| @@ -0,0 +1,2 @@ | |||
| [Origin](https://github.com/AlexeyAB/darknet/blob/c0d6b81a78e204c04c9bf4277974e0dadad0c4e2/cfg/yolov4.cfg) | |||
| [License](https://github.com/AlexeyAB/darknet/blob/c0d6b81a78e204c04c9bf4277974e0dadad0c4e2/LICENSE) | |||
Member
There was a problem hiding this comment.
Can we add it to yolov4.cfg as comments?
# Origin: https://github.com/AlexeyAB/darknet/blob/c0d6b81a78e204c04c9bf4277974e0dadad0c4e2/cfg/yolov4.cfg
# License: https://github.com/AlexeyAB/darknet/blob/c0d6b81a78e204c04c9bf4277974e0dadad0c4e2/LICENSE
Member
Author
There was a problem hiding this comment.
I prefer to keep external files without extra modifications.
Member
There was a problem hiding this comment.
Maybe we can just download it as weights?
Member
Author
There was a problem hiding this comment.
It is better to keep it opencv_extra (like others):
- there is no version control on share for downloaded files (they should not conflict at any time)
- configuration file is small and text based
- we may want to add test for importer without weights in the future (without requirement of huge model weights)
mshabunin
approved these changes
May 27, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main PR: opencv/opencv#17392