add converted conformance gemm tests#1073
Merged
vpisarev merged 5 commits intoopencv:4.xfrom Sep 19, 2023
Merged
Conversation
This comment was marked as spam.
This comment was marked as spam.
13 tasks
566d5e1 to
be9bb53
Compare
e0caeaa to
40cb8de
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge with opencv/opencv#23897.
These tests are converted from onnx gemm conformance tests. They have const C (bias) instead of input C.
googlenet.onnxis updated because it has theReshapeoperator which hard-writes the batch size to be 1, and this goes against the test which has batch 2:Replacing
ReshapewithFlattensolves the problem:Also the current implementation of
Softmaxshould be upgraded as well, since the output ofGemmis with batch and theoratically the output shape ofSoftmaxshould have batch as well (2, 1, 1000) instead of current output shape (2, 1000).Scripts for model and data generation with:
gen_googlenet.py:verify_outputs.py:gen_outs.py: