Skip to content

Test model and data for Scatter & ScatterND from ONNX#1009

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
fengyuentau:scatter_scatternd
Oct 17, 2022
Merged

Test model and data for Scatter & ScatterND from ONNX#1009
asmorkalov merged 1 commit intoopencv:4.xfrom
fengyuentau:scatter_scatternd

Conversation

@fengyuentau
Copy link
Copy Markdown
Member

@fengyuentau fengyuentau commented Sep 25, 2022

@fengyuentau fengyuentau mentioned this pull request Sep 25, 2022
Merged
13 tasks
rogday
rogday reviewed Oct 3, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@rogday rogday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
I think we should update the commit link in testdata/onnx/conformance/README.md

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Oct 17, 2022

Also please squash commits in extra.

@fengyuentau
Copy link
Copy Markdown
Member Author

fengyuentau commented Oct 17, 2022 •
edited
Loading

Thank you! I think we should update the commit link in testdata/onnx/conformance/README.md

@rogday This pr just updated scatter and scatternd related models and data. Should I add a new link instead?

@rogday
Copy link
Copy Markdown
Member

rogday commented Oct 17, 2022

@rogday This pr just updated scatter and scatternd related models and data. Should I add a new link instead?

If you did a partial update, you could add a new link for scatter instead of replacing the old one. The source of the data should be clear.

@fengyuentau
sync conformance tests of scatter_elements from onnx
1fc416b 
sync conformance tests of scatternd from onnx

add commit link for the partial update of scatter and scatternd
@fengyuentau
Copy link
Copy Markdown
Member Author

fengyuentau commented Oct 17, 2022

@rogday This pr just updated scatter and scatternd related models and data. Should I add a new link instead?

If you did a partial update, you could add a new link for scatter instead of replacing the old one. The source of the data should be clear.

Thank you! The commit link for scatter and scatternd has been added.

1 similar comment
@fengyuentau
Copy link
Copy Markdown
Member Author

fengyuentau commented Oct 17, 2022

@rogday This pr just updated scatter and scatternd related models and data. Should I add a new link instead?

If you did a partial update, you could add a new link for scatter instead of replacing the old one. The source of the data should be clear.

Thank you! The commit link for scatter and scatternd has been added.

rogday
rogday approved these changes Oct 17, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@rogday rogday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov merged commit bf61631 into opencv:4.x Oct 17, 2022
@alalek alalek mentioned this pull request Jan 8, 2023
Merged
@fengyuentau fengyuentau mentioned this pull request Mar 14, 2023
Open
48 tasks
@fengyuentau fengyuentau deleted the scatter_scatternd branch December 3, 2024 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rogday rogday rogday approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fengyuentau @asmorkalov @rogday