cudacodec::Videoreader fix YUV color conversion#3828
Merged
asmorkalov merged 1 commit intoopencv:4.xfrom Dec 30, 2024
Merged
Conversation
… Codec SDK sample as a guide
asmorkalov
approved these changes
Dec 30, 2024
Comment on lines
+154
to
+159
| if (format.colorSpaceStandard == ColorSpaceStandard::Unspecified) { | ||
| if (format.width > 1280 || format.height > 720) | ||
| format.colorSpaceStandard = ColorSpaceStandard::BT709; | ||
| else | ||
| format.colorSpaceStandard = ColorSpaceStandard::BT601; | ||
| } |
Contributor
There was a problem hiding this comment.
Is it some heuristic? Do you have any reference for the decision?
Contributor
Author
There was a problem hiding this comment.
Yes, from my understanding 709 is for HD but I could't find a definitive source to say if there was an exact definition of what resolution this starts at. Although many sources mentioned 720p as the minimum resolution in the end I chose 720p as it replicated the color format behaviour from sources decoded with the VideoCapture class.
6 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
VideoReadercolor conversion:Note: Previous attempts to fix this #3468 didn't address (2).
This PR uses the Nvidia Video Codec SDK ColorSpace.cu sample as a guide to:
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.