wechat_qrcode: fix ineffective decoding retrial after inverting image#3818
Merged
asmorkalov merged 1 commit intoopencv:4.xfrom Nov 12, 2024
Doekin:wechat_qrcode
Merged
wechat_qrcode: fix ineffective decoding retrial after inverting image#3818asmorkalov merged 1 commit intoopencv:4.xfrom Doekin:wechat_qrcode
asmorkalov merged 1 commit intoopencv:4.xfrom
Doekin:wechat_qrcode
Conversation
VadimLevin
approved these changes
Nov 1, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a logic error in the
QRCodeReader::decodefunctionwhen handling inverted images. Previously, the function would return
an empty result list even when successful decoding occurred on an
inverted image. The change ensure that:
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.