Get CUDA code to compile with clang CUDA and without CUDA#3800
Merged
asmorkalov merged 6 commits intoopencv:4.xfrom Oct 29, 2024
Merged
Get CUDA code to compile with clang CUDA and without CUDA#3800asmorkalov merged 6 commits intoopencv:4.xfrom
asmorkalov merged 6 commits intoopencv:4.xfrom
Conversation
Contributor
On Windows this is an annoying default in Visual Studio, what errors does clang give from this? I'm concerned that if any new kernel's are added by users of VS then it will brake the clang build. Strangely it build fine for me on Ubuntu 20:04 - clang version 10.0.0-4ubuntu1. |
Contributor
Author
|
Thx @cudawarped . I am ok fixing the |
Contributor
|
@vrabaud Could you add some notes how you build OpenCV + CUDA + Clang. Just to be sure that we are talking about the same thing. |
Contributor
Author
|
@asmorkalov , for my purpose, I do not use nvcc but clang cuda instead. This is all internal to Google so I actually have no idea of the command lines unfortunately. |
Contributor
Author
|
I am done adding missing implementations, PTAL |
asmorkalov
approved these changes
Oct 29, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelist:
<< <-><<<. For some reason, I do not need to change all those in the code.::min->std::minin__host__codemodules/cudaimgproc/src/moments.cppneeds to have the CUDA code in the#ifdefcv::cuda::swapChannelsis not exactly the same as the C++ one inmodules/cudaimgproc/src/color.cppcv::cuda::FarnebackOpticalFlow::createneeds to be explicit about which FarnebackOpticalFlow it returnsPull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request