Skip to content

Fix link error caused by lack of moc in the cvv module during opencv_world build#3630

Open
GengGode wants to merge 1 commit intoopencv:4.xfrom
GengGode:4.x
Open

Fix link error caused by lack of moc in the cvv module during opencv_world build#3630
GengGode wants to merge 1 commit intoopencv:4.xfrom
GengGode:4.x

Conversation

@GengGode
Copy link
Copy Markdown

@GengGode GengGode commented Jan 28, 2024 •
edited by asmorkalov
Loading

fixes : #3629

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

but, A red prompt will appear,need opencv cmakelists fix

@GengGode GengGode mentioned this pull request Jan 28, 2024
Merged
6 tasks
@GengGode
Copy link
Copy Markdown
Author

GengGode commented Jan 28, 2024

need opencv/opencv#24934 To fix the issue where red prompts may appear

@asmorkalov asmorkalov changed the title Fix link error caused by lack of moc in the cvv module during opencv_… Fix link error caused by lack of moc in the cvv module during opencv_world build Feb 5, 2024
asmorkalov
asmorkalov reviewed Jul 25, 2024
View reviewed changes
modules/cvv/CMakeLists.txt
Comment on lines -18 to -19
set(CMAKE_AUTOMOC ON)
set(CMAKE_INCLUDE_CURRENT_DIR ON)
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov Jul 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not work. See https://github.com/opencv/opencv/blob/eab21b61067385515c77783608f8c374bfe131c6/modules/highgui/CMakeLists.txt#L91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov left review comments

Assignees

No one assigned

Labels

category: cvv

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Prompt for unresolved external symbols when compiling CVV modules

2 participants

@GengGode @asmorkalov