Merged
Conversation
‘error’ may be used uninitialized
Contributor
Author
|
There may be clang-tidy warning about reducing scope of the variable, but I decided that it goes outside of the change that I was trying to make, since I was just trying to get rid of console warning. If maintainers think, that I should reduce variable scope too, write here about it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
‘error’ may be used uninitialized.
We used to declare error uninitialized, pass it to
LineFitas OUT parameter, hoping that every path will initializeerrorvarible. But there is path, whereerroris kept uninitialized, so it is better to explicitly initialize it herePull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.