Skip to content

Binding fix for matchLOGOS with python test.#3594

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov:as/matchLOGOS_bindining_fix
Dec 15, 2023
Merged

Binding fix for matchLOGOS with python test.#3594
asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov:as/matchLOGOS_bindining_fix

Conversation

@asmorkalov
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov commented Nov 17, 2023 •
edited
Loading

Fixes #3589

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov force-pushed the as/matchLOGOS_bindining_fix branch 2 times, most recently from 39244ed to 18c68e5 Compare November 17, 2023 10:58
@asmorkalov
Copy link
Copy Markdown
Contributor Author

asmorkalov commented Dec 7, 2023 

 ======================================================================
ERROR: test_basic (test_descriptors.matchLOGOS_test)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/ci/opencv_contrib/modules/xfeatures2d/misc/python/test/test_descriptors.py", line 31, in test_basic
    matches1to2 = cv.matchLOGOS(keypoints1, keypoints2, range(len(keypoints1)), range(len(keypoints2)))
AttributeError: module 'cv2' has no attribute 'matchLOGOS'

----------------------------------------------------------------------

@asmorkalov asmorkalov force-pushed the as/matchLOGOS_bindining_fix branch from 18c68e5 to daded36 Compare December 15, 2023 16:02
@asmorkalov asmorkalov merged commit ab4bfc2 into opencv:4.x Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

category: python bindings category: xfeatures2d

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

matchLOGOS not working with Python

1 participant

@asmorkalov