Skip to content

cudacodec::VideoReader - ensure FormatInfo.valid == true on return from constructor#3486

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
cudawarped:cudacodec_force_valid_format
Jun 21, 2023
Merged

cudacodec::VideoReader - ensure FormatInfo.valid == true on return from constructor#3486
asmorkalov merged 1 commit intoopencv:4.xfrom
cudawarped:cudacodec_force_valid_format

Conversation

@cudawarped
Copy link
Copy Markdown
Contributor

@cudawarped cudawarped commented Apr 28, 2023 •
edited
Loading

As discussed in #3468 (comment) it would be useful if VideoReader::FormatInfo was valid in the constructor to make validation tasks simpler.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@cudawarped cudawarped force-pushed the cudacodec_force_valid_format branch from 25f56ce to 3156de9 Compare April 28, 2023 08:56
@asmorkalov asmorkalov self-requested a review April 28, 2023 10:47
@cudawarped cudawarped force-pushed the cudacodec_force_valid_format branch from 3156de9 to 5cef4af Compare June 10, 2023 05:39
asmorkalov
asmorkalov reviewed Jun 15, 2023
View reviewed changes
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Jun 15, 2023

I apologize for the large delay in review. OpenCV team moved barcode support to main repo. Please rebase your branch on top of current 4.x to continue development. Otherwise you'll see conflicts with current 4.x in main repo.

@cudawarped cudawarped force-pushed the cudacodec_force_valid_format branch from 5cef4af to 44f6fd0 Compare June 16, 2023 08:10
@cudawarped cudawarped force-pushed the cudacodec_force_valid_format branch from 44f6fd0 to d4b55f7 Compare June 16, 2023 08:11
@cudawarped cudawarped mentioned this pull request Jun 20, 2023
Merged
6 tasks
asmorkalov
asmorkalov approved these changes Jun 21, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov self-assigned this Jun 21, 2023
@asmorkalov asmorkalov merged commit 813967b into opencv:4.x Jun 21, 2023
@asmorkalov asmorkalov mentioned this pull request Jul 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels

category: cuda

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cudawarped @asmorkalov