Skip to content

Promote cv::VideoCapture properties in VideoReader#3485

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov:as/cuda_codec_get
May 16, 2023
Merged

Promote cv::VideoCapture properties in VideoReader#3485
asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov:as/cuda_codec_get

Conversation

@asmorkalov
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov commented Apr 27, 2023

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@cudawarped
Copy link
Copy Markdown
Contributor

cudawarped commented Apr 27, 2023 •
edited
Loading

Nice, I can't for the life of me remember why I would have done it the way. Seems error prone looking back if any of the VideoCapture properties failed to be set.

@asmorkalov
Copy link
Copy Markdown
Contributor Author

asmorkalov commented Apr 28, 2023

@cudawarped I reworked tests a bit. Could you take a look again?

cudawarped
cudawarped reviewed Apr 28, 2023
View reviewed changes
cudawarped
cudawarped reviewed Apr 28, 2023
View reviewed changes
@asmorkalov asmorkalov changed the title WIP: Promote cv::VideoCapture properties in VideoReader Promote cv::VideoCapture properties in VideoReader May 3, 2023
@asmorkalov asmorkalov force-pushed the as/cuda_codec_get branch from c8f53f3 to bc3a53b Compare May 3, 2023 11:12
cudawarped
cudawarped reviewed May 3, 2023
View reviewed changes
@asmorkalov asmorkalov force-pushed the as/cuda_codec_get branch from bc3a53b to d4f7f5f Compare May 3, 2023 14:14
@asmorkalov
Copy link
Copy Markdown
Contributor Author

asmorkalov commented May 15, 2023

@cudawarped I restored create-only parameters handling and related tests. Do you have any opens? May I merge the PR?

@cudawarped
Copy link
Copy Markdown
Contributor

cudawarped commented May 16, 2023

LGTM 👍

@asmorkalov asmorkalov self-assigned this May 16, 2023
@asmorkalov asmorkalov merged commit e59b737 into opencv:4.x May 16, 2023
@asmorkalov asmorkalov mentioned this pull request May 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cudawarped cudawarped cudawarped left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@asmorkalov asmorkalov

Labels

bug category: cuda

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@asmorkalov @cudawarped