Skip to content

fix: aruco test tries to pass 2d numpy array as std::vector<int>#3031

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
VadimLevin:dev/vlevin/fix-test-aruco-indices-type
Aug 28, 2021
Merged

fix: aruco test tries to pass 2d numpy array as std::vector<int>#3031
opencv-pushbot merged 1 commit intoopencv:3.4from
VadimLevin:dev/vlevin/fix-test-aruco-indices-type

Conversation

@VadimLevin
Copy link
Copy Markdown
Contributor

@VadimLevin VadimLevin commented Aug 28, 2021

Test utilize error-prone behavior when 2d array is flattened.

Merge before opencv/opencv#20618 , but without this PR indices shape squeeze is required because std::vector<int> is returned as 2d Mat [[1], [2], ...]

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@VadimLevin VadimLevin force-pushed the dev/vlevin/fix-test-aruco-indices-type branch from eeb8d6d to 83b04ee Compare August 28, 2021 20:52
@opencv-pushbot opencv-pushbot merged commit e98a240 into opencv:3.4 Aug 28, 2021
@alalek alalek mentioned this pull request Aug 28, 2021
@alalek alalek mentioned this pull request Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants