Correct width/height returned by cudacodec::VideoReader::FormatInfo()#3001
Merged
alalek merged 2 commits intoopencv:masterfrom Jul 10, 2021
Merged
Correct width/height returned by cudacodec::VideoReader::FormatInfo()#3001alalek merged 2 commits intoopencv:masterfrom
alalek merged 2 commits intoopencv:masterfrom
Conversation
alalek
reviewed
Jul 9, 2021
Comment on lines
+132
to
+134
| format_.height = cap.get(CAP_PROP_FRAME_HEIGHT); | ||
| format_.width = cap.get(CAP_PROP_FRAME_WIDTH); | ||
| format_.displayArea = Rect(0, 0, cap.get(CAP_PROP_FRAME_WIDTH), cap.get(CAP_PROP_FRAME_HEIGHT)); |
Member
There was a problem hiding this comment.
It makes sense to reuse already fetched .get() results instead of querying a new one.
Merged
4 tasks
6 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When decoding certain resolutions (e.g. 1080p), the size of the frame returned from
nextFrame()(1920x1088) can be larger than the usable area (1920x1080) due to the coded sizes being multiples of n bytes, for efficient coding/decoding.This causes a problem in cudacodec because currently the values of width and height returned by
cudaCodec::Format()are different depending on which video source is used. The two possibilities are FFmpeg and cuvid, with FFmpeg returning the usable width and height (1920x1080) and cuvid returning the coded width and height (1920x1088).I think it would make sense for both video sources to return the coded width and height if possible because that corresponds to the dimensions of the frame returned by
nextFrame(). Unfortunately in the case of the FFmpeg backend this won't be known for certain until after the first call tonextFrame()where the decoder may or may not reconfigure itself based on the coded bit stream. To avoid changing the internals of cudacodec too much (it needs a re-write to mirror the existing Nvidia sample code anyway) I have included an ugly hack using a flag to signal if the dimensions of width and height can be relied upon.The accuracy test case has been updated and should fail without this fix.
Additionally I have included the display area so that the frame can be cropped to get the usable area (e.g. 1920x1080 from 1920x1088).
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.