Skip to content

dnn_objdetect: remove highgui header from core_detect.hpp#2518

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
berak:dnn_objdetect_remove_highgui
Apr 30, 2020
Merged

dnn_objdetect: remove highgui header from core_detect.hpp#2518
opencv-pushbot merged 1 commit intoopencv:3.4from
berak:dnn_objdetect_remove_highgui

Conversation

@berak
Copy link
Copy Markdown
Contributor

@berak berak commented Apr 29, 2020

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • [x ] I agree to contribute to the project under OpenCV (BSD) License.
  • [ x] To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • [ x] The PR is proposed to proper branch
  • [ x] There is reference to original bug report and related work
  • [ x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • [ x] The feature is well documented and sample code can be built with the project CMake

this removes a dependancy on highgui.hpp from the core_detect.hpp header, so the module can compile if highgui is disabled from cmake
(it's not needed here, and only the samples should depend on gui)

@berak berak changed the base branch from master to 3.4 April 29, 2020 07:26
@asmorkalov
Copy link
Copy Markdown
Contributor

👍

@asmorkalov asmorkalov self-requested a review April 29, 2020 12:50
@opencv-pushbot opencv-pushbot merged commit 1062808 into opencv:3.4 Apr 30, 2020
@berak berak deleted the dnn_objdetect_remove_highgui branch May 1, 2020 06:25
@alalek alalek mentioned this pull request May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants