Fixed mismatch#2035
Merged
opencv-pushbot merged 1 commit intoopencv:3.4from Apr 30, 2020
kyscg:fix-mismatch
Merged
Conversation
Member
|
As a bugfix this patch should go into 3.4 branch first. We will merge changes from 3.4 into master regularly (weekly/bi-weekly). So, please:
Note: no needs to re-open PR, apply changes "inplace". |
Member
|
@kyscg Please rebase this patch again on the HEAD of "3.4" branch (to resolve conflicts). Thank you! |
Contributor
Author
|
Thanks for the review, is this ready to merge? |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in regard to #1970
I've completed the initial part and I think we now have to change the code, could I have some pointers on how to go about changing the code and subsequent document updation??
Review pleasee?? @alalek @LaurentBerger