Skip to content

int to proper enum type#1730

Closed
cv3d wants to merge 9 commits intoopencv:masterfrom
cv3d:improvements/enum_interface
Closed

int to proper enum type#1730
cv3d wants to merge 9 commits intoopencv:masterfrom
cv3d:improvements/enum_interface

Conversation

@cv3d
Copy link
Copy Markdown
Contributor

@cv3d cv3d commented Aug 23, 2018 •
edited
Loading

Merge with opencv/opencv#12288 and opencv/opencv_extra#515

This pullrequest changes

There are hundreds of unnamed enums, and they are being passed as int in the C++ interface.
In order to avoid passing a wrong value, and to maintain good practices, the hope is to name most of these enums, and change the int arguments into the proper enum types wherever possible.

#force_builders=ARMv7,ARMv8
force_builders=Custom
docker_image:Custom=ubuntu-cuda:16.04

@cv3d cv3d mentioned this pull request Aug 23, 2018
Closed
alalek
alalek reviewed Aug 23, 2018
View reviewed changes
modules/optflow/src/sparse_matching_gpc.cpp Outdated
(int)globSize[0], (int)globSize[1], (int)patchRadius )
.run( 2, globSize, 0, true ) == false )
return false;
Mat cpuOut = out.getMat( 0 );
Copy link
Copy Markdown
Member

@alalek alalek Aug 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACCESS_READ should be here.

@cv3d cv3d force-pushed the improvements/enum_interface branch from b3ee644 to ea0c8be Compare August 23, 2018 10:25
@alalek
Copy link
Copy Markdown
Member

alalek commented Aug 23, 2018

@cv3d Please rebase this patch onto 3.4 branch.

@cv3d cv3d changed the base branch from master to 3.4 August 23, 2018 21:02
@cv3d cv3d force-pushed the improvements/enum_interface branch from ea0c8be to 271f2bc Compare August 23, 2018 21:05
@cv3d cv3d changed the base branch from 3.4 to master August 23, 2018 22:32
@cv3d
Copy link
Copy Markdown
Contributor Author

cv3d commented Aug 23, 2018

@alalek I opened a new PR #1733 instead.
I will keep this PR for future commits related to the int to enum changes

@cv3d cv3d force-pushed the improvements/enum_interface branch 14 times, most recently from a04b8d2 to 80c87b9 Compare August 30, 2018 20:40
@cv3d cv3d force-pushed the improvements/enum_interface branch 7 times, most recently from 4bf90e6 to f7e2c88 Compare September 4, 2018 17:03
@cv3d cv3d force-pushed the improvements/enum_interface branch 11 times, most recently from e0f8c10 to fee14d4 Compare September 12, 2018 19:35
@cv3d cv3d force-pushed the improvements/enum_interface branch 5 times, most recently from 97fd65e to 41564d1 Compare September 16, 2018 20:04
@cv3d cv3d force-pushed the improvements/enum_interface branch 3 times, most recently from fad2209 to b84f892 Compare September 20, 2018 08:32
@cv3d cv3d force-pushed the improvements/enum_interface branch from b84f892 to 0184e33 Compare September 20, 2018 09:47
@vpisarev vpisarev closed this Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cv3d @alalek @vpisarev