Closed
Conversation
this builds on opencv#8492 and opencv#8511 to add a new method, .orientation(), to ImageDecoder. The JPEG subclass now overrides this to do jpeg-specific exif tag reading we also now export a method, OrientationTransform, which uses this orientation value to do the actual matrix operations
apparently python wrapper chokes on this? kinda lame
622e3d1 to
51da45e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please note: This patch builds on #8492 and #8511 so it contains changes from both. I had hoped I could have worked through merging both before doing this but I ended up wanting this patch sooner, so I went ahead and submitted.
This patch takes the exported ImageDecoder from #8511 and adds
.orientation()which is overriden by the JPEG decoder subclass to use the EXIF tag reader to find the orientation metadata. We also now export the function that consumes this orientation value and applies the relevant transforms to normalize aMat&