fixing wrong user guide names#2945
fixing wrong user guide names#2945StevenPuttemans wants to merge 5 commits intoopencv:2.4from StevenPuttemans:bugfix_3777
Conversation
|
I changed the ug_highgui to the ug_kinect. However, I am expecting this to create 2 files. How can I tell in a pull request that the original ug_highgui can be deleted? Someone? |
|
@StevenPuttemans, may be |
doc/user_guide/ug_intelperc.rst
Outdated
There was a problem hiding this comment.
You need more asterisks.
*****************************************
Senz3D and Intel Perceptual Computing SDK
*****************************************
|
I will make the changes as suggest. As to the mv, since I renamed the original file, I have no idea how I have to do a mv on my system now ... ill try with rm or something like that. Get back to you! |
|
It seems a rename and then followed by a remove of the old file did the trick. Lets merge commits now! |
|
It should be correct now. Saw that I also removed a subtitle to much, fixed that now. |
|
Hi Steven! Thanks for PR! |
|
@StevenPuttemans Do you have any thoughts, why two builders were crushed? |
|
Afaik this has nothing to do with this pull request. Others have same error, seems the bug is in the python bindinh of a Mat function. We just need to wait until someone fixes this I guess |
|
👍 |
|
Also it seems that this problem only lives in the 2.4 branch. Is there a way of checking how this problem was fixed in master branch? |
|
I think it is kind of weird that changing docs results in this error test_boundscatch (main.AreaTests) ... OpenCV Error: One of arguments' values is out of range (index is out of range) in cvPtr2D, file C:\builds_ocv\precommit_windows64\opencv\modules\core\src\array.cpp, line 1754 This makes me believe that there is still a problem with current 2.4 branch in the python tests. @Daniil-Osokin Also to add to your remark. The identations were already there, I guess they are accepted because they are inside comment brackets? Would you like me to change them? |
|
Ok it seems this was fixed in #2914 |
…c/window_cocoa.mm (Bug #3737)
…entation fault fixed.
|
I tried fixing it, lets see if I solved it! |
|
Steven, |
|
I will redo it :) next time lets not wait weeks to add little changes like this :D Prolly I did somethng wrong or new changes are interfering :D |
|
#2985 here you go :) |
As mentioned in title
Bug report : code.opencv.org/issues/3777