Skip to content

fixing wrong user guide names#2945

Closed
StevenPuttemans wants to merge 5 commits intoopencv:2.4from
StevenPuttemans:bugfix_3777
Closed

fixing wrong user guide names#2945
StevenPuttemans wants to merge 5 commits intoopencv:2.4from
StevenPuttemans:bugfix_3777

Conversation

@StevenPuttemans
Copy link
Copy Markdown

As mentioned in title

Bug report : code.opencv.org/issues/3777

@StevenPuttemans
Copy link
Copy Markdown
Author

I changed the ug_highgui to the ug_kinect. However, I am expecting this to create 2 files. How can I tell in a pull request that the original ug_highgui can be deleted? Someone?

@vbystricky
Copy link
Copy Markdown

@StevenPuttemans, may be git mv will be good for this?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need more asterisks.

*****************************************
Senz3D and Intel Perceptual Computing SDK
*****************************************

@StevenPuttemans
Copy link
Copy Markdown
Author

I will make the changes as suggest. As to the mv, since I renamed the original file, I have no idea how I have to do a mv on my system now ... ill try with rm or something like that. Get back to you!

@StevenPuttemans
Copy link
Copy Markdown
Author

It seems a rename and then followed by a remove of the old file did the trick. Lets merge commits now!

@StevenPuttemans
Copy link
Copy Markdown
Author

It should be correct now. Saw that I also removed a subtitle to much, fixed that now.

@Daniil-Osokin
Copy link
Copy Markdown

Hi Steven! Thanks for PR!

@Daniil-Osokin
Copy link
Copy Markdown

@StevenPuttemans Do you have any thoughts, why two builders were crushed?

@StevenPuttemans
Copy link
Copy Markdown
Author

Afaik this has nothing to do with this pull request. Others have same error, seems the bug is in the python bindinh of a Mat function.

We just need to wait until someone fixes this I guess

@Daniil-Osokin Daniil-Osokin self-assigned this Jul 9, 2014
@Daniil-Osokin
Copy link
Copy Markdown

👍

@StevenPuttemans
Copy link
Copy Markdown
Author

Also it seems that this problem only lives in the 2.4 branch. Is there a way of checking how this problem was fixed in master branch?

@StevenPuttemans
Copy link
Copy Markdown
Author

I think it is kind of weird that changing docs results in this error

test_boundscatch (main.AreaTests) ... OpenCV Error: One of arguments' values is out of range (index is out of range) in cvPtr2D, file C:\builds_ocv\precommit_windows64\opencv\modules\core\src\array.cpp, line 1754
OpenCV Error: One of arguments' values is out of range (index is out of range) in cvPtr2D, file C:\builds_ocv\precommit_windows64\opencv\modules\core\src\array.cpp, line 1754
OpenCV Error: One of arguments' values is out of range (index is out of range) in cvPtrND, file C:\builds_ocv\precommit_windows64\opencv\modules\core\src\array.cpp, line 1893
OpenCV Error: One of arguments' values is out of range (index is out of range) in cvPtrND, file C:\builds_ocv\precommit_windows64\opencv\modules\core\src\array.cpp, line 1893
OpenCV Error: One of arguments' values is out of range (index is out of range) in cvPtrND, file C:\builds_ocv\precommit_windows64\opencv\modules\core\src\array.cpp, line 1893
OpenCV Error: One of arguments' values is out of range (index is out of range) in cvPtrND, file C:\builds_ocv\precommit_windows64\opencv\modules\core\src\array.cpp, line 1893
OpenCV Error: One of arguments' values is out of range (index is out of range) in cvPtrND, file C:\builds_ocv\precommit_windows64\opencv\modules\core\src\array.cpp, line 1893
OpenCV Error: One of arguments' values is out of range (index is out of range) in cvPtrND, file C:\builds_ocv\precommit_windows64\opencv\modules\core\src\array.cpp, line 1893
OpenCV Error: One of arguments' values is out of range (index is out of range) in cvPtrND, file C:\builds_ocv\precommit_windows64\opencv\modules\core\src\array.cpp, line 1893
OpenCV Error: One of arguments' values is out of range (index is out of range) in cvPtrND, file C:\builds_ocv\precommit_windows64\opencv\modules\core\src\array.cpp, line 1893
OpenCV Error: One of arguments' values is out of range (index is out of range) in cvPtrND, file C:\builds_ocv\precommit_windows64\opencv\modules\core\src\array.cpp, line 1893
OpenCV Error: One of arguments' values is out of range (index is out of range) in cvPtrND, file C:\builds_ocv\precommit_windows64\opencv\modules\core\src\array.cpp, line 1893
OpenCV Error: One of arguments' values is out of range (index is out of range) in cvPtrND, file C:\builds_ocv\precommit_windows64\opencv\modules\core\src\array.cpp, line 1893
OpenCV Error: One of arguments' values is out of range (index is out of range) in cvPtrND, file C:\builds_ocv\precommit_windows64\opencv\modules\core\src\array.cpp, line 1893
OpenCV Error: One of arguments' values is out of range (index is out of range) in cvPtrND, file C:\builds_ocv\precommit_windows64\opencv\modules\core\src\array.cpp, line 1893
OpenCV Error: One of arguments' values is out of range (index is out of range) in cvPtrND, file C:\builds_ocv\precommit_windows64\opencv\modules\core\src\array.cpp, line 1893

This makes me believe that there is still a problem with current 2.4 branch in the python tests.

@Daniil-Osokin Also to add to your remark. The identations were already there, I guess they are accepted because they are inside comment brackets? Would you like me to change them?

@StevenPuttemans
Copy link
Copy Markdown
Author

Ok it seems this was fixed in #2914
I am going to update the fix onto the latest 2.4 release! Will keep in touch!

@StevenPuttemans
Copy link
Copy Markdown
Author

I tried fixing it, lets see if I solved it!

@vpisarev
Copy link
Copy Markdown
Contributor

Steven,
can you please redo the PR? if you check the difference, you will see that it modifies several other files that it should not have done. I actually suggest to create the new PR from scratch (take the modified .rst files)

@vpisarev vpisarev closed this Jul 18, 2014
@StevenPuttemans
Copy link
Copy Markdown
Author

I will redo it :) next time lets not wait weeks to add little changes like this :D Prolly I did somethng wrong or new changes are interfering :D

@StevenPuttemans StevenPuttemans mentioned this pull request Jul 18, 2014
@StevenPuttemans
Copy link
Copy Markdown
Author

#2985 here you go :)

@StevenPuttemans StevenPuttemans deleted the bugfix_3777 branch October 7, 2014 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants