Skip to content

Add 5.x types for DLPack. Keep uint32/int64/uint64 data type for conversion to Numpy. More types support for GpuMat::convertTo#27779

Merged
asmorkalov merged 12 commits intoopencv:5.xfrom
dkurt:dlpack_5.x_types
Sep 25, 2025
Merged

Add 5.x types for DLPack. Keep uint32/int64/uint64 data type for conversion to Numpy. More types support for GpuMat::convertTo#27779
asmorkalov merged 12 commits intoopencv:5.xfrom
dkurt:dlpack_5.x_types

Conversation

@dkurt
Copy link
Copy Markdown
Member

@dkurt dkurt commented Sep 12, 2025 •
edited
Loading

Pull Request Readiness Checklist

Merge with contrib: opencv/opencv_contrib#4000

related: #27581

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Sep 12, 2025 

Failed test with dtype <class 'numpy.uint32'> and 2 channels
test_dlpack_GpuMat (__main__.cuda_test) ... FAIL

======================================================================
FAIL: test_dlpack_GpuMat (__main__.cuda_test)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/ci/opencv/modules/python/test/test_cuda.py", line 159, in test_dlpack_GpuMat
    self.assertTrue(equal)
AssertionError: False is not true

@asmorkalov asmorkalov self-requested a review September 12, 2025 14:32
@dkurt dkurt added this to the 5.0-release milestone Sep 14, 2025
asmorkalov
asmorkalov reviewed Sep 15, 2025
View reviewed changes
asmorkalov
asmorkalov reviewed Sep 17, 2025
View reviewed changes
@dkurt dkurt changed the title Add 5.x types for DLPack Add 5.x types for DLPack. Keep uint32/int64/uint64 data type for conversion to Numpy Sep 18, 2025
@dkurt dkurt changed the title Add 5.x types for DLPack. Keep uint32/int64/uint64 data type for conversion to Numpy Add 5.x types for DLPack. Keep uint32/int64/uint64 data type for conversion to Numpy.More types support for GpuMat::convertTo Sep 20, 2025
@dkurt dkurt changed the title Add 5.x types for DLPack. Keep uint32/int64/uint64 data type for conversion to Numpy.More types support for GpuMat::convertTo Add 5.x types for DLPack. Keep uint32/int64/uint64 data type for conversion to Numpy. More types support for GpuMat::convertTo Sep 20, 2025
@dkurt
Copy link
Copy Markdown
Member Author

dkurt commented Sep 20, 2025

Let's wait for opencv/ci-gha-workflow#258 and rerun the tests

@dkurt dkurt marked this pull request as ready for review September 23, 2025 18:26
@dkurt dkurt mentioned this pull request Sep 23, 2025
Merged
6 tasks
asmorkalov
asmorkalov reviewed Sep 24, 2025
View reviewed changes
@asmorkalov asmorkalov self-assigned this Sep 24, 2025
@asmorkalov asmorkalov merged commit 4159c0a into opencv:5.x Sep 25, 2025
25 of 26 checks passed
@opencv-alalek opencv-alalek mentioned this pull request Oct 2, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels

category: gpu/cuda (contrib) OpenCV 4.0+: moved to opencv_contrib category: python bindings

Projects

None yet

Milestone

5.0-release

Development

Successfully merging this pull request may close these issues.

2 participants

@dkurt @asmorkalov