Skip to content

Added extra test tag for Qualcomm DSP (disabled by default)#27360

Closed
asmorkalov wants to merge 1 commit intoopencv:4.xfrom
asmorkalov:as/test_tag_dsp
Closed

Added extra test tag for Qualcomm DSP (disabled by default)#27360
asmorkalov wants to merge 1 commit intoopencv:4.xfrom
asmorkalov:as/test_tag_dsp

Conversation

@asmorkalov
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov commented May 26, 2025

Merge with opencv/opencv_contrib#3947

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

#if defined(_DEBUG)
testSkipWithTags.push_back(CV_TEST_TAG_DEBUG_VERYLONG);
#endif
testSkipWithTags.push_back(CV_TEST_TAG_DSP);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is "skip list".
It should not contain target device by default.

Also tags of external tests could by filtered in / filtered out through command-line parameters. So we don't need this patch.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want the test to be disabled by default. DSP is available not in all Qualcomm chipsets. We do not have reliable way to check it till initialize FastCV API. What is alternative then? BTW, there is CV_TEST_TAG_OPENCL.

@asmorkalov
Copy link
Copy Markdown
Contributor Author

Closed. Found local solution for fastcv module itself.

@asmorkalov asmorkalov closed this May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants