Skip to content

Fix #27352: Add checks before getting latest pin in Net::Impl::getLatestLayerPin()#27353

Merged
asmorkalov merged 3 commits intoopencv:4.xfrom
MRo47:fix/segfault-on-forward#27352
May 24, 2025
Merged

Fix #27352: Add checks before getting latest pin in Net::Impl::getLatestLayerPin()#27353
asmorkalov merged 3 commits intoopencv:4.xfrom
MRo47:fix/segfault-on-forward#27352

Conversation

@MRo47
Copy link
Copy Markdown
Contributor

@MRo47 MRo47 commented May 23, 2025 •
edited
Loading

Pull Request Readiness Checklist

Fixes #27352

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@MRo47 MRo47 marked this pull request as ready for review May 23, 2025 14:21
@MRo47 MRo47 changed the title add empty check before getting max element Fix #27352: Add checks before getting latest pin in Net::Impl::getLatestLayerPin() May 23, 2025
@asmorkalov asmorkalov requested review from dkurt and vpisarev May 24, 2025 05:57
dkurt
dkurt approved these changes May 24, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@dkurt dkurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge

@asmorkalov asmorkalov added this to the 4.12.0 milestone May 24, 2025
@asmorkalov asmorkalov merged commit 374ad41 into opencv:4.x May 24, 2025
24 of 28 checks passed
@asmorkalov asmorkalov mentioned this pull request May 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkurt dkurt dkurt approved these changes

@vpisarev vpisarev Awaiting requested review from vpisarev

Assignees

@dkurt dkurt

Labels

category: dnn

Projects

None yet

Milestone

4.12.0

Development

Successfully merging this pull request may close these issues.

Segfault when Net::Impl::forward(OutputArrayOfArrays outputBlobs, const std::vector<String>& outBlobNames) is called with empty outBlobNames

3 participants

@MRo47 @dkurt @asmorkalov