build: fix more warnings from recent gcc versions after #27337#27343
Merged
asmorkalov merged 4 commits intoopencv:4.xfrom May 21, 2025
Merged
build: fix more warnings from recent gcc versions after #27337#27343asmorkalov merged 4 commits intoopencv:4.xfrom
asmorkalov merged 4 commits intoopencv:4.xfrom
Conversation
fengyuentau
commented
May 21, 2025
| int nNewAllocatedSize = anPrimes[set->nIndiceAllocatedSize]; | ||
| TIFFList **newTabList = | ||
| (TIFFList **)(calloc(sizeof(TIFFList *), nNewAllocatedSize)); | ||
| (TIFFList **)(calloc(nNewAllocatedSize, sizeof(TIFFList *))); |
Member
Author
There was a problem hiding this comment.
Upstream of libtiff has fixed this: https://gitlab.com/libtiff/libtiff/-/blob/master/libtiff/tif_hash_set.c#L370
| set->fnFreeEltFunc = fnFreeEltFunc; | ||
| set->nSize = 0; | ||
| set->tabList = (TIFFList **)(calloc(sizeof(TIFFList *), 53)); | ||
| set->tabList = (TIFFList **)(calloc(53, sizeof(TIFFList *))); |
Member
Author
There was a problem hiding this comment.
Upstream of libtiff has fixed this: https://gitlab.com/libtiff/libtiff/-/blob/master/libtiff/tif_hash_set.c#L149
asmorkalov
approved these changes
May 21, 2025
asmorkalov
approved these changes
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More fixings after #27337
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.