Skip to content

Fix bug in solvePoly test#27342

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
MaximSmolskiy:fix-bug-in-solvePoly-test
May 21, 2025
Merged

Fix bug in solvePoly test#27342
asmorkalov merged 1 commit intoopencv:4.xfrom
MaximSmolskiy:fix-bug-in-solvePoly-test

Conversation

@MaximSmolskiy
Copy link
Copy Markdown
Contributor

Pull Request Readiness Checklist

In test TEST(Core_SolvePoly, regression_5599) function checkRoot is used for checking that obtained roots contain all expected roots. To properly check multiple roots (roots with multiplicity greater than 1) it should check that some root is presented exactly several times. For this in function there is logic to assign found roots to NaN but it didn't work because it used root copy instead of reference for it.

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov merged commit dc61086 into opencv:4.x May 21, 2025
20 of 28 checks passed
@MaximSmolskiy MaximSmolskiy deleted the fix-bug-in-solvePoly-test branch May 21, 2025 08:19
@asmorkalov asmorkalov mentioned this pull request May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants