Skip to content

imgproc: vectorize mode CHISQR and CHISQR_ALT in compareHist#27334

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
fengyuentau:4x/imgproc/compareHist_chisqr_simd
May 21, 2025
Merged

imgproc: vectorize mode CHISQR and CHISQR_ALT in compareHist#27334
asmorkalov merged 1 commit intoopencv:4.xfrom
fengyuentau:4x/imgproc/compareHist_chisqr_simd

Conversation

@fengyuentau
Copy link
Copy Markdown
Member

@fengyuentau fengyuentau commented May 19, 2025

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@fengyuentau fengyuentau added this to the 4.12.0 milestone May 19, 2025
@fengyuentau fengyuentau requested a review from asmorkalov May 19, 2025 09:12
@fengyuentau
Copy link
Copy Markdown
Member Author

fengyuentau commented May 19, 2025 •
edited
Loading

Performance numbers:

  • K1 (RISC-V)

GCC

           Name of Test            base-gcc patch-gcc patch-gcc 
                                                          vs    
                                                       base-gcc 
                                                      (x-factor)
compareHist::Dim_Cmpmethod::(1, 1)  0.069     0.018      3.78   
compareHist::Dim_Cmpmethod::(1, 4)  0.073     0.019      3.83   
compareHist::Dim_Cmpmethod::(3, 1) 562.695   139.774     4.03   
compareHist::Dim_Cmpmethod::(3, 4) 594.465   146.604     4.05

Clang

           Name of Test            base-clang patch-clang patch-clang
                                                              vs     
                                                          base-clang 
                                                          (x-factor) 
compareHist::Dim_Cmpmethod::(1, 1)   0.073       0.022       3.39    
compareHist::Dim_Cmpmethod::(1, 4)   0.077       0.022       3.52    
compareHist::Dim_Cmpmethod::(3, 1)  594.879     169.226      3.52    
compareHist::Dim_Cmpmethod::(3, 4)  626.672     171.879      3.65
  • RK3568 (ARM A55)
           Name of Test            perf-base perf-patch perf-patch
                                                            vs
                                                        perf-base
                                                        (x-factor)
compareHist::Dim_Cmpmethod::(1, 1)   0.052     0.017       3.07
compareHist::Dim_Cmpmethod::(1, 4)   0.058     0.019       3.08
compareHist::Dim_Cmpmethod::(3, 1)  432.470   137.963      3.13
compareHist::Dim_Cmpmethod::(3, 4)  476.554   151.592      3.14
  • Intel i7 12700K
           Name of Test            base-x64 patch-x64 patch-x64
                                                          vs
                                                       base-x64
                                                      (x-factor)
compareHist::Dim_Cmpmethod::(1, 1)  0.004     0.004      1.20
compareHist::Dim_Cmpmethod::(1, 4)  0.004     0.004      1.15
compareHist::Dim_Cmpmethod::(3, 1)  15.183   11.445      1.33
compareHist::Dim_Cmpmethod::(3, 4)  15.765   11.909      1.32

@asmorkalov asmorkalov self-assigned this May 21, 2025
@asmorkalov asmorkalov merged commit 79a5e52 into opencv:4.x May 21, 2025
53 of 55 checks passed
@fengyuentau fengyuentau deleted the 4x/imgproc/compareHist_chisqr_simd branch May 21, 2025 05:01
@asmorkalov asmorkalov mentioned this pull request May 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels

category: imgproc optimization

Projects

None yet

Milestone

4.12.0

Development

Successfully merging this pull request may close these issues.

2 participants

@fengyuentau @asmorkalov