Skip to content

Add tests for solveCubic#27331

Merged
asmorkalov merged 2 commits intoopencv:4.xfrom
MaximSmolskiy:add-test-for-solveCubic
May 21, 2025
Merged

Add tests for solveCubic#27331
asmorkalov merged 2 commits intoopencv:4.xfrom
MaximSmolskiy:add-test-for-solveCubic

Conversation

@MaximSmolskiy
Copy link
Copy Markdown
Contributor

Pull Request Readiness Checklist

Related to #27323

I found only randomized tests with number of roots always equal to 1 or 3, x^3 = 0 and some simple test for Java and Swift.
Obviously, they don't cover all cases (implementation has strong branching and number of roots can be equal to -1, 0 and 2 additionally).
So, I think it will be useful to try explicitly cover more cases (and implementation branches correspondingly)

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov added this to the 4.12.0 milestone May 19, 2025
@asmorkalov asmorkalov self-requested a review May 19, 2025 06:01
@asmorkalov asmorkalov self-assigned this May 19, 2025
@asmorkalov asmorkalov merged commit d00738d into opencv:4.x May 21, 2025
52 of 55 checks passed
@MaximSmolskiy MaximSmolskiy deleted the add-test-for-solveCubic branch May 21, 2025 05:37
@asmorkalov asmorkalov mentioned this pull request May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants