Skip to content

cmake: set SPNG_LIBRARY for pkgconfig as well#27314

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
parona-source:fix-libspng-pkgconfig
May 15, 2025
Merged

cmake: set SPNG_LIBRARY for pkgconfig as well#27314
asmorkalov merged 1 commit intoopencv:4.xfrom
parona-source:fix-libspng-pkgconfig

Conversation

@parona-source
Copy link
Copy Markdown
Contributor

@parona-source parona-source commented May 14, 2025

Pkgconfig will set SPNG_LIBRARIES but not SPNG_LIBRARY, this is an issue as modules/imgcodecs/CmakeLists.txt uses SPNG_LIBRARY.

Bug: https://bugs.gentoo.org/955661
Fixes: c928152

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@parona-source
cmake: set SPNG_LIBRARY for pkgconfig as well
8fae4a6 
Pkgconfig will set SPNG_LIBRARIES but not SPNG_LIBRARY, this is an issue
as modules/imgcodecs/CmakeLists.txt uses SPNG_LIBRARY.

Bug: https://bugs.gentoo.org/955661
Fixes: c928152
Signed-off-by: Alfred Wingate <parona@protonmail.com>
@asmorkalov asmorkalov self-requested a review May 15, 2025 05:08
@asmorkalov asmorkalov self-assigned this May 15, 2025
@asmorkalov asmorkalov added this to the 4.12.0 milestone May 15, 2025
asmorkalov
asmorkalov approved these changes May 15, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@asmorkalov asmorkalov merged commit 8ceddbf into opencv:4.x May 15, 2025
25 of 28 checks passed
@asmorkalov asmorkalov mentioned this pull request May 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels

category: build/install category: 3rdparty

Projects

None yet

Milestone

4.12.0

Development

Successfully merging this pull request may close these issues.

2 participants

@parona-source @asmorkalov