Skip to content

Update match_template.py to fix doc bug#27293

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
shirriff:patch-1
May 12, 2025
Merged

Update match_template.py to fix doc bug#27293
asmorkalov merged 1 commit intoopencv:4.xfrom
shirriff:patch-1

Conversation

@shirriff
Copy link
Copy Markdown
Contributor

@shirriff shirriff commented May 7, 2025

shape has Y first, then X. See issue #27292

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov self-requested a review May 12, 2025 07:46
@asmorkalov
Copy link
Copy Markdown
Contributor

@shirriff Thanks a lot for the finding! Looks like the same issue exists in 4.x branch. Could you rebase the PR and re-target it to 4.x. The fix will be propagated to 5.x with regular merge process.

@asmorkalov asmorkalov added this to the 4.12.0 milestone May 12, 2025
@asmorkalov asmorkalov self-assigned this May 12, 2025
shape has Y first, then X. See issue opencv#27292
@asmorkalov asmorkalov changed the base branch from 5.x to 4.x May 12, 2025 14:07
@asmorkalov asmorkalov merged commit 90e7119 into opencv:4.x May 12, 2025
27 of 28 checks passed
@shirriff
Copy link
Copy Markdown
Contributor Author

@shirriff Could you rebase the PR and re-target it to 4.x.

It looks like you did this already. Is there anything I need to do?

@asmorkalov
Copy link
Copy Markdown
Contributor

No, thanks.

@asmorkalov asmorkalov mentioned this pull request May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants