Skip to content

Migrated IPP impl for flip and transpose to HAL#27194

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov:as/ipp_transpose
Apr 10, 2025
Merged

Migrated IPP impl for flip and transpose to HAL#27194
asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov:as/ipp_transpose

Conversation

@asmorkalov
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov commented Apr 3, 2025

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov added optimization cleanup Code cleanup (e.g, drop legacy C-API, legacy unmaintained code) labels Apr 3, 2025
@asmorkalov asmorkalov added this to the 4.12.0 milestone Apr 3, 2025
@asmorkalov asmorkalov changed the title Migrated IPP impl for flip and transpose to HAL WIP: Migrated IPP impl for flip and transpose to HAL Apr 3, 2025
@asmorkalov asmorkalov changed the title WIP: Migrated IPP impl for flip and transpose to HAL Migrated IPP impl for flip and transpose to HAL Apr 3, 2025
@asmorkalov asmorkalov force-pushed the as/ipp_transpose branch 2 times, most recently from fc755df to 56f194c Compare April 8, 2025 06:29
@asmorkalov
Copy link
Copy Markdown
Contributor Author

asmorkalov commented Apr 8, 2025

@mshabunin @opencv-alalek Could you take a look? I hacked the build issue.

opencv-alalek
opencv-alalek reviewed Apr 8, 2025
View reviewed changes
3rdparty/ipphal/CMakeLists.txt
endif()

if(HAVE_IPP_IW)
target_compile_definitions(ipphal PRIVATE HAVE_IPP_IW)
Copy link
Copy Markdown
Contributor

@opencv-alalek opencv-alalek Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRIVATE?

This macro is used in "interface" headers.

Copy link
Copy Markdown
Contributor Author

@asmorkalov asmorkalov Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Fixed.

Copy link
Copy Markdown
Contributor Author

@asmorkalov asmorkalov Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like I cannot make it public for now. We get redefinition issue. The macros are defined by both HAL and IPP core. I made it private for now to exclude the redefinition issue and added note to CMake.

@asmorkalov asmorkalov force-pushed the as/ipp_transpose branch 2 times, most recently from e1fb39d to 9b2af00 Compare April 10, 2025 05:20
@asmorkalov asmorkalov merged commit 6ef5746 into opencv:4.x Apr 10, 2025
27 of 28 checks passed
@asmorkalov asmorkalov mentioned this pull request Apr 29, 2025
Merged
@asmorkalov asmorkalov mentioned this pull request May 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@opencv-alalek opencv-alalek opencv-alalek approved these changes

@mshabunin mshabunin Awaiting requested review from mshabunin

Assignees

@opencv-alalek opencv-alalek

Labels

category: core cleanup Code cleanup (e.g, drop legacy C-API, legacy unmaintained code) optimization

Projects

None yet

Milestone

4.12.0

Development

Successfully merging this pull request may close these issues.

2 participants

@asmorkalov @opencv-alalek