Skip to content

More elegant skipping SOLVEPNP_IPPE* methods in non-planar accuracy tests for solvePnP*#27174

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
MaximSmolskiy:more_elegant_skipping_SOLVEPNP_IPPE_methods_in_non_planar-accuracy-tests-for_solvePnP
Mar 31, 2025
Merged

More elegant skipping SOLVEPNP_IPPE* methods in non-planar accuracy tests for solvePnP*#27174
asmorkalov merged 1 commit intoopencv:4.xfrom
MaximSmolskiy:more_elegant_skipping_SOLVEPNP_IPPE_methods_in_non_planar-accuracy-tests-for_solvePnP

Conversation

@MaximSmolskiy
Copy link
Copy Markdown
Contributor

It's more unified - in one place (in one function instead of two before).
It gives clearer log:

mode: no distortion, method: SOLVEPNP_IPPE -> Skip for non-planar object
mode: no distortion, method: SOLVEPNP_IPPE_SQUARE -> Skip for non-planar tag object

instead of

mode: no distortion, method: SOLVEPNP_IPPE -> 100% (maxErrT: -1, maxErrR: -1, meanErrT: -1, meanErrR: -1, medErrT: -1, medErrR: -1)
approximate translation threshold for 0.7: -1, approximate rotation threshold for 0.7: -1
mode: no distortion, method: SOLVEPNP_IPPE_SQUARE -> 100% (maxErrT: -1, maxErrR: -1, meanErrT: -1, meanErrR: -1, medErrT: -1, medErrR: -1)
approximate translation threshold for 0.7: -1, approximate rotation threshold for 0.7: -1

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov self-assigned this Mar 31, 2025
@asmorkalov asmorkalov added this to the 4.12.0 milestone Mar 31, 2025
@asmorkalov asmorkalov merged commit 9d34a88 into opencv:4.x Mar 31, 2025
21 of 28 checks passed
@MaximSmolskiy MaximSmolskiy deleted the more_elegant_skipping_SOLVEPNP_IPPE_methods_in_non_planar-accuracy-tests-for_solvePnP branch March 31, 2025 06:40
@asmorkalov asmorkalov mentioned this pull request Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants