Skip to content

Fix closing of windows when using the Qt backend#27170

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
Osse:qt-fix-closing-window
Mar 31, 2025
Merged

Fix closing of windows when using the Qt backend#27170
asmorkalov merged 1 commit intoopencv:4.xfrom
Osse:qt-fix-closing-window

Conversation

@Osse
Copy link
Copy Markdown
Contributor

@Osse Osse commented Mar 28, 2025

Notify the main GUI thread upon receiving a close event instead of when
the windows is destroyed. Additionally there was a logic error in in
GuiReceiver::isLastWindow() that is corrected.

Fixes #6479 and #20822

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

Notify the main GUI thread upon receiving a close event instead of when
the windows is destroyed. Additionally there was a logic error in in
GuiReceiver::isLastWindow() that is corrected.

Fixes opencv#6479 and opencv#20822
@asmorkalov asmorkalov added this to the 4.12.0 milestone Mar 30, 2025
@asmorkalov asmorkalov self-requested a review March 30, 2025 10:31
@asmorkalov asmorkalov self-assigned this Mar 30, 2025
@asmorkalov
Copy link
Copy Markdown
Contributor

Tested manually with Ubuntu 24.04 and QT 6.

@asmorkalov asmorkalov merged commit d0c5a04 into opencv:4.x Mar 31, 2025
21 of 28 checks passed
@asmorkalov asmorkalov mentioned this pull request Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Opencv with Qt cmd remains after actual opencv window is closed when it should be closed also

3 participants