Skip to content

HAL: added copyToMask and implemented in hal_rvv#27162

Merged
asmorkalov merged 3 commits intoopencv:4.xfrom
fengyuentau:4x/hal_rvv/copyMask
Mar 31, 2025
Merged

HAL: added copyToMask and implemented in hal_rvv#27162
asmorkalov merged 3 commits intoopencv:4.xfrom
fengyuentau:4x/hal_rvv/copyMask

Conversation

@fengyuentau
Copy link
Copy Markdown
Member

@fengyuentau fengyuentau commented Mar 27, 2025

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@fengyuentau fengyuentau added this to the 4.12.0 milestone Mar 27, 2025
@fengyuentau fengyuentau requested a review from asmorkalov March 27, 2025 09:30
@fengyuentau
Copy link
Copy Markdown
Member Author

fengyuentau commented Mar 27, 2025 •
edited
Loading

Performance results: perf-copyMask.zip

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Mar 31, 2025

My perf numbers for Muse Pi v 30 (gcc 14.2):

Mat_CopyToWithMask::Size_MatType::(127x61, 8UC1) 	0.004 	0.004 	1.01
Mat_CopyToWithMask::Size_MatType::(127x61, 16UC1) 	0.009 	0.012 	0.75
Mat_CopyToWithMask::Size_MatType::(127x61, 32SC1) 	0.024 	0.019 	1.28
Mat_CopyToWithMask::Size_MatType::(127x61, 8UC2) 	0.009 	0.012 	0.77
Mat_CopyToWithMask::Size_MatType::(127x61, 8UC3) 	0.038 	0.023 	1.68
Mat_CopyToWithMask::Size_MatType::(127x61, 32FC4) 	0.056 	0.047 	1.19
Mat_CopyToWithMask::Size_MatType::(1920x1080, 8UC1) 	1.485 	1.408 	1.05
Mat_CopyToWithMask::Size_MatType::(1920x1080, 16UC1) 	2.778 	2.200 	1.26
Mat_CopyToWithMask::Size_MatType::(1920x1080, 32SC1) 	4.352 	3.466 	1.26
Mat_CopyToWithMask::Size_MatType::(1920x1080, 8UC2) 	2.765 	2.208 	1.25
Mat_CopyToWithMask::Size_MatType::(1920x1080, 8UC3) 	9.234 	2.815 	3.28
Mat_CopyToWithMask::Size_MatType::(1920x1080, 32FC4) 	13.534 	11.559 	1.17

@asmorkalov asmorkalov self-assigned this Mar 31, 2025
@asmorkalov asmorkalov merged commit ec1cbe2 into opencv:4.x Mar 31, 2025
53 of 55 checks passed
@fengyuentau fengyuentau deleted the 4x/hal_rvv/copyMask branch March 31, 2025 07:49
@asmorkalov asmorkalov mentioned this pull request Apr 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels

optimization platform: riscv

Projects

OpenCV 4.x HAL improvement
Status: Done

Milestone

4.12.0

Development

Successfully merging this pull request may close these issues.

2 participants

@fengyuentau @asmorkalov