Skip to content

doc: js: unwrap promise-typed cv object#27148

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
Kumataro:fix27129
Mar 26, 2025
Merged

doc: js: unwrap promise-typed cv object#27148
asmorkalov merged 1 commit intoopencv:4.xfrom
Kumataro:fix27129

Conversation

@Kumataro
Copy link
Copy Markdown
Contributor

@Kumataro Kumataro commented Mar 25, 2025 •
edited by opencv-alalek
Loading

Close #27129

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
force_builders=Custom
build_image:Docs=docs-js
build_image:Custom=javascript
buildworker:Custom=linux-1,linux-4,linux-f1

@Kumataro
Copy link
Copy Markdown
Contributor Author

Kumataro commented Mar 25, 2025

Unfortunately, we cannot check this fix on the preview where opencv.js is not installed.

https://pullrequest.opencv.org/buildbot/export/pr/27148/docs/d0/d84/tutorial_js_usage.html

@Kumataro
Copy link
Copy Markdown
Contributor Author

Kumataro commented Mar 25, 2025

@opencv-alalek Thank you to custom CI/CD setting, we can confirm that it works fine in preview.

@opencv-alalek opencv-alalek added this to the 4.12.0 milestone Mar 26, 2025
opencv-alalek
opencv-alalek approved these changes Mar 26, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@opencv-alalek opencv-alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kumataro Thank you 👍

@asmorkalov asmorkalov merged commit 9a1f71c into opencv:4.x Mar 26, 2025
26 of 28 checks passed
@asmorkalov asmorkalov mentioned this pull request Apr 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@opencv-alalek opencv-alalek opencv-alalek approved these changes

Assignees

@opencv-alalek opencv-alalek

Labels

bug category: documentation Documentation fix or update category: java bindings

Projects

None yet

Milestone

4.12.0

Development

Successfully merging this pull request may close these issues.

Basic example for opencv.js doesn't work with version 4.11.0 and later

3 participants

@Kumataro @opencv-alalek @asmorkalov