Skip to content

When WARP_INVERSE_MAP is used, accelerate the calculation with multi-threading#27108

Merged
asmorkalov merged 5 commits intoopencv:4.xfrom
Scorpion1234567:Multithreading-wrapPolar
Mar 20, 2025
Merged

When WARP_INVERSE_MAP is used, accelerate the calculation with multi-threading#27108
asmorkalov merged 5 commits intoopencv:4.xfrom
Scorpion1234567:Multithreading-wrapPolar

Conversation

@Scorpion1234567
Copy link
Copy Markdown
Contributor

@Scorpion1234567 Scorpion1234567 commented Mar 20, 2025 •
edited
Loading

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Mar 20, 2025

OpenCV has parallel_for_ api for the purpose. OpenCV may use other frameworks than OpenMP. Mix of OpenMP with outher threading frameworks may lead to deadlocks and performance degradation. Please re-write the code with parallel_for_. You can use overload with lambda.

@Scorpion1234567
Copy link
Copy Markdown
Contributor Author

Scorpion1234567 commented Mar 20, 2025

I have made the corresponding revisions according to your suggestions. Please review them again. Thank you!

asmorkalov
asmorkalov reviewed Mar 20, 2025
View reviewed changes
@Scorpion1234567
Copy link
Copy Markdown
Contributor Author

Scorpion1234567 commented Mar 20, 2025

Thank you for your correction. I have already made the revision.

@asmorkalov asmorkalov self-assigned this Mar 20, 2025
@asmorkalov asmorkalov added this to the 4.12.0 milestone Mar 20, 2025
@Scorpion1234567
Copy link
Copy Markdown
Contributor Author

Scorpion1234567 commented Mar 20, 2025

Thank you very much for modifying my code. Since this is my first pull request, could you please tell me what I need to do next?

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Mar 20, 2025

Nothing on your side for now. Give me some time.

@Scorpion1234567
Copy link
Copy Markdown
Contributor Author

Scorpion1234567 commented Mar 20, 2025

thank you

@asmorkalov asmorkalov merged commit 2e93455 into opencv:4.x Mar 20, 2025
24 of 28 checks passed
@asmorkalov asmorkalov mentioned this pull request Apr 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels

category: imgproc optimization

Projects

None yet

Milestone

4.12.0

Development

Successfully merging this pull request may close these issues.

2 participants

@Scorpion1234567 @asmorkalov